-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Switch to &vector notation in the iterators chapter. #22612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@@ -242,6 +242,9 @@ for num in nums.iter() { | |||
} | |||
``` | |||
|
|||
Sometimes you need this functionality, but since for loops operate on the | |||
`IntoIterator` trait, calling `.iter()` is rarely necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not that rare; any time one wishes to call the iterator adaptor methods it is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest a better wording? I'm afraid I don't know very much about iterator adaptor methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just drop it entirely
r? @steveklabnik I've updated the iterators chapter to reflect the fact that you can now iterate over `for` loops without calling `.iter()`.
r? @steveklabnik I've updated the iterators chapter to reflect the fact that you can now iterate over `for` loops without calling `.iter()`.
r? @steveklabnik
I've updated the iterators chapter to reflect the fact that you can now iterate over
for
loops without calling.iter()
.