Skip to content

Switch to &vector notation in the iterators chapter. #22612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2015

Conversation

jxcl
Copy link
Contributor

@jxcl jxcl commented Feb 21, 2015

r? @steveklabnik

I've updated the iterators chapter to reflect the fact that you can now iterate over for loops without calling .iter().

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@@ -242,6 +242,9 @@ for num in nums.iter() {
}
```

Sometimes you need this functionality, but since for loops operate on the
`IntoIterator` trait, calling `.iter()` is rarely necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that rare; any time one wishes to call the iterator adaptor methods it is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest a better wording? I'm afraid I don't know very much about iterator adaptor methods.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just drop it entirely

@steveklabnik
Copy link
Member

@bors: r+ 9f2b067 rollup

bombless added a commit to bombless/rust that referenced this pull request Feb 23, 2015
r? @steveklabnik 

I've updated the iterators chapter to reflect the fact that you can now iterate over `for` loops without calling `.iter()`.
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 23, 2015
 r? @steveklabnik

I've updated the iterators chapter to reflect the fact that you can now iterate over `for` loops without calling `.iter()`.
@alexcrichton alexcrichton merged commit 9f2b067 into rust-lang:master Feb 23, 2015
@jxcl jxcl deleted the iter-replace branch February 23, 2015 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants